Conversation
bcoe
approved these changes
Nov 2, 2023
vchudnov-g
approved these changes
Nov 2, 2023
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
Only a minor, non-blocking comment.
| util.strtobool(os.getenv("GOOGLE_API_USE_CLIENT_CERTIFICATE", "false")) | ||
| ) | ||
|
|
||
| use_client_cert = os.getenv("GOOGLE_API_USE_CLIENT_CERTIFICATE", "false") |
Contributor
There was a problem hiding this comment.
Might as well us lower() in this assignment so you don't have to repeat it below
(It would be great to cast this to a bool like the previous code was doing, but it seems like too much overhead for the very limited use in a very compact LOC range. The string comparison is OK.)
…is/python-api-core into drop-usage-of-distutils
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507 🦕
ValueErrorif the format of theGOOGLE_API_USE_CLIENT_CERTIFICATEis not as defined belowpython-api-core/google/api_core/operations_v1/abstract_operations_client.py
Lines 275 to 280 in 405272c
This is the same behaviour that exists in
gapic-generator-pythonhere https://github.com/googleapis/gapic-generator-python/blob/45f18a69454bcff68c0f98535c68fbdb4e09db1d/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/client.py.j2#L253-L256